Dev container fixes and updates#1173
Merged
Merged
Conversation
More robust handling of unusual filenames. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the dev container configuration and supporting scripts, removing unused dependencies and enhancing documentation. Key changes include:
- A new script (scripts/count-changes) to count Solidity code changes using cloc.
- Removal of the shared network dependency and duplicate Git SSH signing message in the dev container settings.
- Updates to the Dockerfile to remove global Hardhat installation and install only the necessary packages.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/count-changes | Adds a script for counting Solidity code changes using cloc. |
| packages/issuance/lib/forge-std | Adds a submodule commit reference for the forge-std library. |
| .devcontainer/project-setup.sh | Removes a duplicate Git SSH signing message to avoid redundancy. |
| .devcontainer/docker-compose.yml | Removes the unneeded shared network configuration. |
| .devcontainer/README.md | Updates documentation for clarity regarding container usage. |
| .devcontainer/Dockerfile | Eliminates global Hardhat installation; now installs ethers and cloc. |
Without a container name will automatically be picked based on dir
tmigone
previously approved these changes
May 23, 2025
tmigone
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes and updates:
scripts/count-changes not about dev container but useful script.
Everything else relates just to dev container configuration.